Added custom data-cy label for Select component#2472
Merged
deepanshu-rajput-git merged 1 commit intoApr 15, 2025
Conversation
Contributor
Author
|
@sojanvarghese _a, Please review. |
sojanvarghese
approved these changes
Apr 15, 2025
Contributor
sojanvarghese
left a comment
sojanvarghese
left a comment
There was a problem hiding this comment.
LGTM, @deepanshu-rajput-git _a
deepanshu-rajput-git
deleted the
2471-add-custom-datacy-label-to-select-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added:
dataCyprop to Select component.Checklist
I have made corresponding changes to the documentation.I have updated the types definition of modified exports.I have verified the functionality in some of the neeto web-apps.
I have added tests that prove my fix is effective or that my feature works.I have added proper
data-cyanddata-testidattributes.I have added the necessary label (
patch/minor/major- If package publishis required).
Reviewers
patch _t
@deepanshu-rajput-git _a